fix(review): show loading state in review scope selector dialog#5733
Open
krisztian-gajdar wants to merge 5 commits intoKilo-Org:mainfrom
Open
fix(review): show loading state in review scope selector dialog#5733krisztian-gajdar wants to merge 5 commits intoKilo-Org:mainfrom
krisztian-gajdar wants to merge 5 commits intoKilo-Org:mainfrom
Conversation
My original problem was that when there were many changes the modal was slow to appear and clicking on the ui cancelled the modal from appearing Now we display loading spinner immediately when opening review scope dialog while scope information is being computed. This improves perceived performance by showing UI feedback instantly rather than waiting for the git operations to complete. - Send null scopeInfo initially to trigger loading state - Add loading spinner and text in ReviewScopeSelector - Disable start review button while loading - Update tests for new loading behavior
…-review-modal-loading
🦋 Changeset detectedLatest commit: 2c7ed00 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
My original problem was that when there were many changes the modal was slow to appear and clicking on the ui cancelled the modal from appearing
Now we display loading spinner immediately when opening review scope dialog
while scope information is being computed. This improves perceived
performance by showing UI feedback instantly rather than waiting for
the git operations to complete.
Implementation
How to Test
Open a workspace that is a git repository with some uncommitted changes (for greater affect changed files should be in the hundreds)
Switch to Review mode (via the mode selector)
Previously the Review Scope Selection dialog did not appear for many seconds but now it should appear with a loading state while git data is being fetched
After a moment, the dialog should populate with scope options (uncommitted changes, branch comparison)
Get in Touch
krisztian-gajdar