Skip to content

Commit

Permalink
build: Don't ship GTEST headers in install target
Browse files Browse the repository at this point in the history
A project that uses googletest(GTEST) shouldn't include googletest
headers with its artifacts in its install target.  These headers
simply are not needed by the consumers of the install target and
can cause conflicts with other projects that use googletest
themselves and this project's install target.  And they are just not
part of the expected glslang build artifacts.

It is likely that the addition of the googletest headers to the install
target was a simple oversight that happens as a result of adding
googletest as a CMake subdirectory.

For more information on how this causes conflicts with other projects,
please see: KhronosGroup/Vulkan-ValidationLayers#821.
  • Loading branch information
karl-lunarg committed Apr 2, 2019
1 parent e0d59bb commit 1d1fd88
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion External/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ if(BUILD_TESTING)
if(WIN32)
set(gtest_force_shared_crt ON CACHE BOOL "" FORCE)
endif(WIN32)
add_subdirectory(googletest)
# EXCLUDE_FROM_ALL keeps the install target from installing GTEST files.
add_subdirectory(googletest EXCLUDE_FROM_ALL)
set(GTEST_TARGETS
gtest
gtest_main
Expand Down

0 comments on commit 1d1fd88

Please sign in to comment.