Set gl_PointSize in primitive restart tests for GL_POINTS. #3367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks all texture formats for filterable and color-renderable. WebGL 1 and 2. WebGL 1's RGB8 doesn't look like it's spec-required. Should it be? Every device and browser I tested supports it, and it's color-renderable in ES3/webgl2.
Failing to set this was relying on currently-undefined behavior and causing the tests to fail on Apple's M1. Related to KhronosGroup#2818, KhronosGroup#2822 and KhronosGroup#3356.
|
Oops, sorry. The branch history for this PR is messed up. Closing, will reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing to set this was relying on currently-undefined behavior and
causing the tests to fail on Apple's M1.
Related to #2818, #2822 and #3356.