Allow duplicate failure messages in layer validation tests #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shannon-lunarg
force-pushed
the
shannon-duplicate_failure_messages
branch
from
860756b to
2338131
Compare
shannon-lunarg
requested review from
mark-lunarg,
mikes-lunarg,
daveh-lunarg,
jeremyk-lunarg and
jzulauf-lunarg
shannon-lunarg
force-pushed
the
shannon-duplicate_failure_messages
branch
from
2338131 to
b9da36d
Compare
shannon-lunarg
changed the title
mark-lunarg
approved these changes
Jun 20, 2018
shannon-lunarg
force-pushed
the
shannon-duplicate_failure_messages
branch
from
b9da36d to
056c9ba
Compare
Unordered multiset allows for multiple expected failure messages Change-Id: I0dc44becc90209c34848b2e91b2d2e92507dc731
Outstanding message count becomes unnecessary with use of unordered multiset Change-Id: I0465d61ccca5b176b8689756c167fb4df075c8ec
shannon-lunarg
force-pushed
the
shannon-duplicate_failure_messages
branch
from
056c9ba to
5014504
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issuing multiple calls to SetDesiredFailureMsg() using the same VUID is now supported.
Resolves #87 (LVL #2639)