-
Notifications
You must be signed in to change notification settings - Fork 342
Rework the readme #2358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Rework the readme #2358
Conversation
|
Is there a reason you want to rework the readme? |
|
Hi @asuessenbach! I've been meaning to do this for a while, actually. I have a list of things that I found a little less than ideal with the current readme:
If you're OK with this, I can proceed with making these changes, naturally subject to your review at the end. I hope to improve the documentation at the end of this exercise. |
|
You're more than welcome to rework the readme! |
9896e08 to
c2a3479
Compare
- Remove HTML hyperlinks; markdown generates automatically - Use backticks \` to demarcate config macros - Remove `VULKAN_HPP_NO_STD_MODULE` option
- `-` instead of `*` - Spaces around lists
86cebc2 to
581d2fe
Compare
- Minor changes to main readme so that links work
- Minor changes in main readme
- Add builder pattern
4a2fb83 to
576fd7a
Compare
|
@asuessenbach, this is still in progress (and hence in draft mode), but do feel free to have a look at the branch to see the direction I'm going in. Hopefully intend to complete this by the end of the year. |
|
How about adding CMake's include(FetchContent)
FetchContent_Declare(vulkan-hpp
GIT_REPOSITORY "https://github.com/KhronosGroup/Vulkan-Hpp.git"
GIT_TAG "v1.4.336" # release tag, commit hash or branch name
GIT_SHALLOW ON)
FetchContent_MakeAvailable(vulkan-hpp) |
|
For the "Build Instructions", it is likely best to separate header generation and sample/test building. At the very least, the build section should state that building is purely for those tasks and that headers can be used by just including them. For merely using the headers (because e.g. they haven't landed in Vulkan-Headers yet), quickly showing how to link against |
|
Both good points @M2-TE. I am focusing mostly on |
- Rework flow; start with vulkan fundamentals - Move things around - Adhere to 1 sentence, 1 line
70f1aba to
293eca2
Compare
- Added TODOs for review - Added section on `std::expected`
No description provided.