-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tighten synchronization scope specification #1843
Draft
krOoze
wants to merge
1
commit into
KhronosGroup:main
Choose a base branch
from
krOoze:sync_scopes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -49,6 +49,7 @@ | |
:onequarter: ¼ | ||
:ldots: … | ||
:forall: ∀ | ||
:exists: ∃ | ||
:sqrt: √ | ||
:inf: ∞ | ||
:plusmn: ± | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the use of predicate logic here is great. This seems intuitive and also more precise than the current spec.
I'm wondering what you think about this potential adjustment, which uses some more of the current wording:
The reasoning being that, at least to me, this makes it a bit more clear that
*B'*
can include operations that are submitted later. The note you have below clarifies this, which is great, but I think it would be nice if we could have this be really clear just from the main text of the spec, so that the note is less essential.Arguably the update I'm suggesting is a bit redundant, because the predicates already "select" the operations, but I do think it reduces the need for the extra note. (My understanding is notes are meant to be more of an optional extra, and not essential for understanding the spec).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for late answer. Yea it is somewhat annoying B is a temporal set. One has to go outside spacetime to see the full extent of B.
Notes\comments are always desperate measures. Make no mistake, I would do everyting humanely possible to try to eliminate them.
What you suggest is there originally, and what I wanted to avoid, because it makes several inaccurate preassumptions. For example, let's say S is a
vkWaitForFences
. What does it even mean "submittingvkWaitForFences
in order with B"? There's not even any queue to establish order. The thing that actually says what is covered by the synchronization, is the synchronization scope, not the order in which operations are submitted. For some hypothetical new S command, A should even be submitted after S, because why not (it could be sync command designed to establish dependency between two things in the future that are yet to be submitted).