Switch from MS-MPI to Intel MPI for the Windows installer#1056
Draft
bruno-at-orange wants to merge 15 commits into
Draft
Switch from MS-MPI to Intel MPI for the Windows installer#1056bruno-at-orange wants to merge 15 commits into
bruno-at-orange wants to merge 15 commits into
Conversation
d3d05ab to
f455df6
Compare
On Windows with Intel MPI, khiops_env.cmd does not need _khiopsgetprocnumber. Khiops can be launched with `mpiexec MODL.exe` without the `-n` flag. We use the same pattern in install.cmake for windows and Linux.
- fix khiops_env when proc number <=2 - fix broken path in khiops_env.in
- replace fragile Windows %VAR% string comparisons with if defined / if not defined - avoid parsing failures when MPI command contains quoted paths with spaces
f455df6 to
183a2cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows Packaging (NSIS installer)
mpiexec.exe,impi.dll,hydra_*) directly in the installer instead of relying on MS-MPI as a prerequisiteKhiopsPrerequisiteFunc.nsh,KhiopsGlobals.nsh) — Intel MPI is now bundled, no separate install neededIntel-MPI-LICENSE.txt,README.txt)_khiopsgetprocnumber.exe(no longer needed)Windows Scripts
khiops_env.cmd.in— Updated to discover/use Intel MPI'smpiexecinstead of MS-MPIset_proc_number.cmd— Updated for Intel MPICMake / Build
CI / GitHub Actions
INTEL_MPI_BIN_DIRandINTEL_MPI_LICENSES_DIRto the NSIS buildTests