fix: use sysconfig to locate khiops_env.cmd on Windows#592
Merged
Conversation
bruno-at-orange
force-pushed
the
try_fix_windows_without_env
branch
from
7d4e314 to
1de746b
Compare
popescu-v
force-pushed
the
try_fix_windows_without_env
branch
11 times, most recently
from
b36add3 to
d0607c6
Compare
Collaborator
|
The first 2 commits authored by @bruno-at-orange LGTM. |
tramora
approved these changes
Jun 30, 2026
| # hence, it is hard-coded | ||
| image: |- | ||
| ghcr.io/khiopsml/khiops-python/khiopspydev-${{ matrix.container }}:${{ inputs.image-tag || 'latest' }} | ||
| env: |
Collaborator
There was a problem hiding this comment.
As a reader I would like to know why for a specific env I will have only "use-virtualenv: true" test for example. Is it the right place here to add a comment for each item ?
popescu-v
force-pushed
the
try_fix_windows_without_env
branch
from
d0607c6 to
588f8f6
Compare
tramora
approved these changes
Jun 30, 2026
popescu-v
force-pushed
the
try_fix_windows_without_env
branch
from
588f8f6 to
fab5295
Compare
On Windows without a virtual environment, sys.executable points to
the Python binary directory (e.g. C:\Python312\) while pip installs
console scripts into the Scripts\ subdirectory. Using
Path(sys.executable).parent therefore missed khiops_env.cmd.
Replace with sysconfig.get_path("scripts") which always returns the
correct Scripts directory for the active Python environment, covering
virtual envs, system installs, and user installs. Also check the
user-scheme scripts dir (nt_user) as a fallback for pip install --user.
…elper
- Replace if/elif chain with a match/case on installation_method for
clarity; each case now owns its full lookup logic
- Extract _infer_khiops_env_from_path() helper (shutil.which + error)
used by 'conda' and 'pip'-on-Unix cases
- Fix 'conda' and 'pip'+Unix cases: return value of helper was
previously discarded, leaving khiops_env_path unbound
- Fix 'pip' case: restore missing distribution('khiops-core') check
- pip + Windows: use sysconfig.get_path('scripts') / 'nt_user' scheme
determined by whether this library lives under user site-packages,
avoiding a blind directory search and correctly handling venv,
system-wide and --user installs
…tests Thests are now run using the `khiops-core` Pip package which ships with the MODL* binaries.
…tualenv Use platforms (GitHub runners, Docker images) that are pristine with respect to Khiops (no native packages or any Khiops-specific support installed.
impi-rt is not present on TestPyPI, whence the installation fails otherwise.
Put comments before switching logic for consistency with the code base.
popescu-v
force-pushed
the
try_fix_windows_without_env
branch
from
fab5295 to
62c02fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows without a virtual environment, sys.executable points to the Python binary directory (e.g. C:\Python312) while pip installs console scripts into the Scripts\ subdirectory. Using Path(sys.executable).parent therefore missed khiops_env.cmd.
Replace with sysconfig.get_path("scripts") which always returns the correct Scripts directory for the active Python environment, covering virtual envs, system installs, and user installs. Also check the user-scheme scripts dir (nt_user) as a fallback for pip install --user.
Put your message here
TODO Before Asking for a Review
main(ormain-v10)Unreleasedsection ofCHANGELOG.md(no date)index.html