DatePicker: Allow date segments to be incremented with the arrow keys in DatePickerInput - #3191
Open
marcysutton wants to merge 1 commit into
Open
DatePicker: Allow date segments to be incremented with the arrow keys in DatePickerInput#3191marcysutton wants to merge 1 commit into
marcysutton wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 1b8602f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (f987de4) and published all packages with changesets to npm. You can install the packages in ./dev/tools/deploy_wonder_blocks.js --tag="PR3191"Packages can also be installed manually by running: pnpm add @khanacademy/wonder-blocks-<package-name>@PR3191 |
Contributor
|
Size Change: +977 B (+0.74%) Total Size: 133 kB 📦 View Changed
ℹ️ View Unchanged
|
Contributor
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-vjafkhtlsf.chromatic.com/ Chromatic results:
|
ArrowUp/ArrowDown adjust the day/month/year segment under the input caret for numeric date formats, matching native date/time inputs. Text formats (e.g. spelled-out month names) are unaffected. Split out of WB-2425-date-picker-activation into its own PR per request; this branch is stacked on top of it.
marcysutton
force-pushed
the
WB-2431-numeric-input
branch
from
August 28, 2026 22:47
ee771a6 to
1b8602f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
To make the DatePicker work more like the native time input, we allow the arrow keys to adjust numeric date segments in the date picker input.
Issue: WB-2431
Test plan:
/?path=/story/packages-datepicker-datepicker--date-and-time-comparison&globals=theme:thunderblocks