Animation tokens - applied to a handful of WB components - #3161
Draft
jonahgoldsaito wants to merge 13 commits into
Draft
Animation tokens - applied to a handful of WB components#3161jonahgoldsaito wants to merge 13 commits into
jonahgoldsaito wants to merge 13 commits into
Conversation
…flags Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…tion, fillMode Extracts the token-system improvements discovered while applying the tokens to components onto the base branch, so the first PR ships a complete, self-consistent system: - Rename the in-place overlay archetype to `floating` and add a distinct `docked` archetype for edge-docked surfaces (drawers/sheets). - Add the `cssTransition` adapter (timing-only CSS transitions, the counterpart to `cssPreset`'s mount/unmount keyframe) and a `fillMode` option on `cssPreset`/`waapiPreset` for exit animations; export `AnimationFillMode` and `CssTransition` types. - Retune the floating/docked durations, easings, and offsets after seeing them in action (emphasized decelerate/accelerate curves; floating rises without scaling). - Reconcile the semantic test, docstrings, one-pager, and token docs stories with the retuned source values (source of truth). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
First round of applying the animation token system (floating/docked presets, cssPreset/cssTransition adapters) to Wonder Blocks components, building on the token architecture now living on the base branch: - Modal / Drawer: mount/unmount via `cssPreset(animation.floating|docked.*)`, backdrops share the panel clock, `modal-launcher` gains an `animated` option. - Accordion: first-open expand/collapse via the `disclosure` preset. - Progress spinner: loop via the `loop.spin` token. - Tabs: indicator movement via `cssTransition(animation.indicator.move)`. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 7e18914 The changes in this PR will be included in the next version bump. This PR includes changesets to release 31 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Size Change: +1.66 kB (+1.27%) Total Size: 133 kB 📦 View Changed
ℹ️ View Unchanged
|
Contributor
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (f8ba6ac) and published all packages with changesets to npm. You can install the packages in ./dev/tools/deploy_wonder_blocks.js --tag="PR3161"Packages can also be installed manually by running: pnpm add @khanacademy/wonder-blocks-<package-name>@PR3161 |
Contributor
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-olzwnzjqfn.chromatic.com/ Chromatic results:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.