Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove locked labels flags #2065

Open
wants to merge 2 commits into
base: remove-locked-figure-flags-2
Choose a base branch
from

Conversation

nishasy
Copy link
Contributor

@nishasy nishasy commented Dec 28, 2024

Summary:

Remove all the locked-[figureName]-labels flags from the Perseus repo
now that the visible labels have been out for a while.

This includes:

  • locked-point-labels
  • locked-line-labels
  • locked-vector-labels
  • locked-ellipse-labels
  • locked-polygon-labels
  • locked-function-labels

Issue: https://khanacademy.atlassian.net/browse/LEMS-2274

Test plan:

yarn jest

@nishasy nishasy self-assigned this Dec 28, 2024
Copy link
Contributor

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (c24f575) and published it to npm. You
can install it using the tag PR2065.

Example:

yarn add @khanacademy/perseus@PR2065

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR2065

@nishasy nishasy requested a review from a team December 28, 2024 01:08
Copy link
Contributor

Size Change: -377 B (-0.03%)

Total Size: 1.27 MB

Filename Size Change
packages/perseus-editor/dist/es/index.js 688 kB -138 B (-0.02%)
packages/perseus/dist/es/index.js 417 kB -239 B (-0.06%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 39 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 78 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus/dist/es/strings.js 4.93 kB
packages/pure-markdown/dist/es/index.js 3.67 kB
packages/simple-markdown/dist/es/index.js 12.5 kB

compressed-size-action

@nishasy nishasy marked this pull request as ready for review December 28, 2024 01:09
Copy link
Member

@catandthemachines catandthemachines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a great milestone to remove these flags! This highlights all the great work to add this experience into Perseus. Approved! Just wait to land into main until after the holidays. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants