-
Notifications
You must be signed in to change notification settings - Fork 138
websocket: gracefully close connection #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
benjaminjkraft
merged 4 commits into
Khan:main
from
HaraldNordgren:unsub_before_closing
Oct 28, 2025
Merged
websocket: gracefully close connection #402
benjaminjkraft
merged 4 commits into
Khan:main
from
HaraldNordgren:unsub_before_closing
Oct 28, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73502bf to
358c94f
Compare
949ecf6 to
9a5c3d9
Compare
9a5c3d9 to
6c18c82
Compare
a8db2b4 to
aa3e09f
Compare
Contributor
Author
aa3e09f to
6ca7528
Compare
6ca7528 to
b14a348
Compare
benjaminjkraft
approved these changes
Oct 28, 2025
Collaborator
benjaminjkraft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Collaborator
|
@HaraldNordgren it looks like there's a test flake possibly due to this? |
benjaminjkraft
added a commit
that referenced
this pull request
Oct 28, 2025
Open
Contributor
Author
|
@benjaminjkraft Ouch, this is bad. If I just add this diff --git a/internal/integration/integration_test.go b/internal/integration/integration_test.go
index 88e9238..99b6055 100644
--- a/internal/integration/integration_test.go
+++ b/internal/integration/integration_test.go
@@ -281,6 +281,7 @@ func TestSubscriptionClose(t *testing.T) {
require.NoError(t, err)
if tc.unsub {
+ time.Sleep(100 * time.Millisecond)
err = wsClient.Unsubscribe(subscriptionID)
require.NoError(t, err)
}then it gets stuck every time. |
Contributor
Author
|
@benjaminjkraft Draft for possible fix: #407 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #399.