Skip to content

fix: emoji in headlines#35

Open
KevinGimbel wants to merge 3 commits intomainfrom
34/fix-emoji-headlines
Open

fix: emoji in headlines#35
KevinGimbel wants to merge 3 commits intomainfrom
34/fix-emoji-headlines

Conversation

@KevinGimbel
Copy link
Copy Markdown
Owner

This fixes #34

@noverby
Copy link
Copy Markdown

noverby commented Feb 16, 2026

Looks good to me 👍

@KevinGimbel
Copy link
Copy Markdown
Owner Author

Overall it's looking good, but it is kinda hard to test. Sometimes the test_is_emoji_randomized test fails, I think it fails if an emoji contains multiple code points.

In test_is_emoji_fixed a similar problem exists, where some emoji like 🕵️‍♀️ (Female Detective) cannot be used because a single char cannot contain two code points.

I'll give this another nights' sleep and see if I can come up with some real tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Strip emojis from link-anchors

2 participants