Skip to content

Added reset & fix memory leak when unmount parent #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added reset & fix memory leak when unmount parent #9

wants to merge 3 commits into from

Conversation

@alesanderlopez
Copy link

@alesanderlopez alesanderlopez commented Jul 30, 2018

Counter.js

  • added method: [reset] to reset the counter again to start.
  • added method: [componentWillUnmount] to stop the counter and fix memory leak when Unmount parent view or change view in react-native-router-flux.
  • updated method: [animate] for stop the loop when the componentWillUnmount was executed.

Readme.md

  • added example to call reset from parent view.

@alesanderlopez
Update Counter.js
88c8448 
- added method: [reset] to reset the counter again to start.
- added method: [componentWillUnmount] to stop the counter and fix memory leak when Unmount parent view or change view in react-native-router-flux
- update method: [animate] for stop the loop when the componentWillUnmount was executed
@alesanderlopez
Update Counter.js
406521c
@alesanderlopez
Update README.md
f5b7bab
ywongweb pushed a commit to ywongweb/react-native-counter that referenced this pull request Sep 14, 2018
fix: add alesanderlopez's fix
462a55a 
Kerumen#9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@alesanderlopez