Skip to content

Fix infinite creation of firstHeaderViewHolder #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rt1shnik wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix infinite creation of firstHeaderViewHolder #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions library/src/main/java/com/kelin/scrollablepanel/library/ScrollablePanel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ public class ScrollablePanel extends FrameLayout {
protected PanelLineAdapter panelLineAdapter;
protected PanelAdapter panelAdapter;
protected FrameLayout firstItemView;
protected RecyclerView.ViewHolder firstHeaderViewHolder;

public ScrollablePanel(Context context, PanelAdapter panelAdapter) {
super(context);
Expand Down Expand Up @@ -55,9 +56,11 @@ private void initView() {
}

private void setUpFirstItemView(PanelAdapter panelAdapter) {
RecyclerView.ViewHolder viewHolder = panelAdapter.onCreateViewHolder(firstItemView, panelAdapter.getItemViewType(0, 0));
panelAdapter.onBindViewHolder(viewHolder, 0, 0);
firstItemView.addView(viewHolder.itemView);
if (firstHeaderViewHolder == null) {
firstHeaderViewHolder = panelAdapter.onCreateViewHolder(firstItemView, panelAdapter.getItemViewType(0, 0));
firstItemView.addView(firstHeaderViewHolder.itemView);
}
panelAdapter.onBindViewHolder(firstHeaderViewHolder, 0, 0);
}

public void notifyDataSetChanged() {
Expand Down