Skip to content

Comments

Extract Taclets and Prover Main Loop to ncore#3578

Merged
Drodt merged 142 commits intoKeYProject:mainfrom
Drodt:ncore-taclets
May 23, 2025
Merged

Extract Taclets and Prover Main Loop to ncore#3578
Drodt merged 142 commits intoKeYProject:mainfrom
Drodt:ncore-taclets

Conversation

@Drodt
Copy link
Member

@Drodt Drodt commented Mar 5, 2025

Intended Change

This pull request is part of the modularization effort in KeY. It contains the first building blocks for generalizing the prover infrastructure, this includes the sequent data structure, as well as proof object, goal, rule, and the prover main loop.

Type of pull request

  • Refactoring (behaviour should not change or only minimally change)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • There are changes to the (Java) code

Ensuring quality

  • I made sure that introduced/changed code is well documented (javadoc and inline comments).
  • I have checked that runtime performance has not deteriorated.

Additional information and contact(s)

The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.

@Drodt Drodt self-assigned this Apr 30, 2025
@Drodt Drodt requested review from mattulbrich and wadoon May 9, 2025 12:32
@Drodt Drodt mentioned this pull request May 14, 2025
1 task
wadoon and others added 3 commits May 15, 2025 20:59
@Drodt Drodt enabled auto-merge May 23, 2025 12:21
@Drodt Drodt dismissed mattulbrich’s stale review May 23, 2025 12:22

All points have been addressed (see KaKeY from 2025-05-09)

@Drodt Drodt added this pull request to the merge queue May 23, 2025
Merged via the queue into KeYProject:main with commit 888bee0 May 23, 2025
7 of 9 checks passed
@Drodt Drodt deleted the ncore-taclets branch May 23, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🛠 Maintenance Code quality and related things w/o functional changes Review Request Waiting for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants