-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reactivate Checkstyle #3539
base: main
Are you sure you want to change the base?
Reactivate Checkstyle #3539
Conversation
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
9a1b5bd
to
9d5b60b
Compare
Missing check, if no Java files were altered. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3539 +/- ##
=========================================
Coverage 38.39% 38.39%
Complexity 17238 17238
=========================================
Files 2099 2099
Lines 127342 127342
Branches 21446 21446
=========================================
Hits 48890 48890
Misses 72440 72440
Partials 6012 6012 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
If there is confusion, should that not be cleared first? What is the confusion about? |
This was just an euphemism for we agreed on Sonarcube, set up the rules, and someone deactivates it. This leads to questions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The newly introduced check still fails.
Regarding tools like SonarCube:
CodeQuality measuring gates help improve the code. However, they must work properly. If they fail consistently and are not repaired, they should be turned off.
Reporting is done via job summary, sarif upload, and build artifact.
a430484
to
a827455
Compare
1947eb5
to
a827455
Compare
Someone deactivated Sonarqube. We seem to have a deeper inner confusion with our common understanding of clean code.
First, this PR reactivates the Checkstyle on changed files still within Gradle.
origin/main
. This solution does not respect lines.Second, it also brings some updates w.r.t. deprecation warnings and hints in/for Gradle.
task.register
is prior to justtask <name>
due to laziness in initialization$buildDir
is deprecated and we should uselayout.buildDirectory
enabled
switch is used for activation/deactiviation.