Fix Visual Studio crashes related to nans and uninitialized variables. #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -278,6 +278,12 @@ void CSFXMgr::HandleSFXMsg(HLOCALOBJ hObj, ILTMessage_Read *pMsg) | |||
| debris.vPos = pMsg->ReadCompPos(); | |||
| debris.nDebrisId = pMsg->Readuint8(); | |||
|
|
|||
| if (std::isnan(debris.rRot.m_Quat[0]) || std::isnan(debris.rRot.m_Quat[1]) | |||
| || std::isnan(debris.rRot.m_Quat[2]) || std::isnan(debris.rRot.m_Quat[3])) | |||
There was a problem hiding this comment.
maybe have the logical or at the end of the previous line than at the beginning of the...
it would more clearly convey that the tests are continuing on the next line.
and LTRotation has a [] operator to access the m_Quat member instead of accessing it directly:
https://github.com/Katana-Steel/lithtech/blob/linux-x86_64/sdk/inc/ltrotation.h#L133
Specifically, this fixes a crash when exploding the gas tank in the inner yard in Chapter 5.
|
Changes made, sorry for the long delay! |
|
No worries, your time is yours. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, this fixes a crash when exploding the gas tank in the inner yard in Chapter 5.