Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print greater-than-equal as >= for inputs.ka #673

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ethulhu
Copy link
Contributor

@ethulhu ethulhu commented Jul 12, 2023

This PR:

  • Adds a function counter_is_eq to determine whether a counter check is >= or =.
  • Adds a second %obs to tests/integration/compiler/counters/counters.ka to check the difference between >= and =.
  • Updates various test reference files.

This PR resolves Issue #672 specifically, but may not be a complete solution for the whole project. For example, core/symmetries/kade_backend.ml has a similar issue, and core/siteGraphs/snapshot.ml has a similar function that may have similar effects elsewhere in the codebase.

@antoinepouille antoinepouille force-pushed the master branch 7 times, most recently from 12d7eb3 to cbe52dd Compare September 12, 2024 17:05
@antoinepouille antoinepouille force-pushed the master branch 4 times, most recently from 49f9863 to 9f2c5b7 Compare September 26, 2024 14:54
@feret feret force-pushed the master branch 3 times, most recently from 1ab81f8 to 79a08c8 Compare November 5, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant