Fix phpdoc types #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you need help with this? I tried helping the original repository, but I am being ignored there. I think what is missing are these cases: |
|
@BladeMF This PR is just dirty fix and should be completed, just I didn't get around to merge it. It'd be nice if you could review it. Feel free to add phpstan and psalm keywords. |
|
I'd rather start doing small PRs for each feature one at a time, including yours. I can create a task list and tick them off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix for phpdoc types, there is more changes needed to implement more complex types e.g. generics
Fixed problems: