fix(SourceCode): OnFallback default generation #2122
Merged
+23
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding a `onFallback` property in the `circuitBreaker` EIP, it's nested one additional level, making the route fail. This commit adds a default value for `onFallback` to fix this issue. fix: KaotoIO#2119
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2122 +/- ##
=========================================
Coverage 81.64% 81.64%
Complexity 456 456
=========================================
Files 538 538
Lines 17044 17046 +2
Branches 3580 3581 +1
=========================================
+ Hits 13915 13917 +2
Misses 2870 2870
Partials 259 259 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
igarashitm
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When adding a
onFallbackproperty in thecircuitBreakerEIP, it's nested one additional level, making the route fail.Changes
This commit adds a default value for
onFallbackto fix this issue.fix: #2119