Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Document Export): Beans missing parameters other than name, type … #2101

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

igarashitm
Copy link
Contributor

…and properties

Fixes: #2093

Screenshot From 2025-03-18 16-52-16

Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.10%. Comparing base (c9cf51c) to head (23386d6).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2101      +/-   ##
============================================
+ Coverage     81.09%   81.10%   +0.01%     
  Complexity      451      451              
============================================
  Files           537      537              
  Lines         16751    16760       +9     
  Branches       3278     3176     -102     
============================================
+ Hits          13584    13593       +9     
- Misses         2905     3083     +178     
+ Partials        262       84     -178     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@igarashitm
Copy link
Contributor Author

sonarcloud says it's unnecessary to add ! here
Screenshot From 2025-03-18 17-27-56

but without ! it gets a compile error

src/services/parsers/beans-parser.ts:24:63 - error TS2345: Argument of type 'Properties | undefined' is not assignable to parameter of type 'Record<string, any>'.
  Type 'undefined' is not assignable to type 'Record<string, any>'.

24         const parsedProperties = CommonParser.parseParameters(bean.properties);
                                                                 ~~~~~~~~~~~~~~~


Found 1 error in src/services/parsers/beans-parser.ts:2

@lordrip
Copy link
Member

lordrip commented Mar 19, 2025

@igarashitm perhaps we could deal with undefined parameters in the method so we don't need to use ! on production code

Copy link
Member

@lordrip lordrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try to find an alternative to the ! but 😃

@igarashitm
Copy link
Contributor Author

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beans only have name and type in route export
2 participants