Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replace embedded catalog of Camel 4.9 by 4.10 #2001

Closed
wants to merge 1 commit into from

Conversation

apupier
Copy link
Member

@apupier apupier commented Feb 11, 2025

No description provided.

@lhein lhein added the rebase This PR branch is out of date and needs a rebase. label Feb 11, 2025
@apupier apupier force-pushed the camel4.10InEmebddedCatalog branch from 0317829 to b57b306 Compare February 12, 2025 08:11
@apupier apupier removed the rebase This PR branch is out of date and needs a rebase. label Feb 12, 2025
@apupier apupier force-pushed the camel4.10InEmebddedCatalog branch from b57b306 to e846313 Compare February 12, 2025 08:36
@apupier
Copy link
Member Author

apupier commented Feb 12, 2025

The code to generate the catalog will need to be adapted for Camel 4.10:

Error: [@kaoto/kaoto]: src/models/visualization/flows/nodes/mappers/choice-node-mapper.test.ts(18,35): error TS2345: Argument of type '"when"' is not assignable to parameter of type 'keyof ProcessorDefinition'.
Error: [@kaoto/kaoto]: src/models/visualization/flows/nodes/mappers/choice-node-mapper.test.ts(19,35): error TS2345: Argument of type '"otherwise"' is not assignable to parameter of type 'keyof ProcessorDefinition'.
Error: [@kaoto/kaoto]: src/models/visualization/flows/nodes/mappers/otherwise-node-mapper.test.ts(39,60): error TS2322: Type '"otherwise"' is not assignable to type 'keyof ProcessorDefinition'.
Error: [@kaoto/kaoto]: src/models/visualization/flows/nodes/mappers/otherwise-node-mapper.ts(14,11): error TS2322: Type '"otherwise"' is not assignable to type 'keyof ProcessorDefinition'.
Error: [@kaoto/kaoto]: src/models/visualization/flows/nodes/mappers/when-node-mapper.test.ts(42,60): error TS2322: Type '"when"' is not assignable to type 'keyof ProcessorDefinition'.
Error: [@kaoto/kaoto]: src/models/visualization/flows/nodes/mappers/when-node-mapper.ts(14,11): error TS2322: Type '"when"' is not assignable to type 'keyof ProcessorDefinition'.
Error: [@kaoto/kaoto]: src/models/visualization/flows/nodes/node-mapper.service.ts(38,40): error TS2345: Argument of type '"when"' is not assignable to parameter of type 'keyof ProcessorDefinition'.
Error: [@kaoto/kaoto]: src/models/visualization/flows/nodes/node-mapper.service.ts(39,40): error TS2345: Argument of type '"otherwise"' is not assignable to parameter of type 'keyof ProcessorDefinition'.
Error: [@kaoto/kaoto]: src/models/visualization/flows/support/camel-component-default.service.ts([10](https://github.com/KaotoIO/kaoto/actions/runs/13281234951/job/37079865601?pr=2001#step:8:11)0,12): error TS2678: Type '"when"' is not comparable to type 'keyof ProcessorDefinition'.
Error: [@kaoto/kaoto]: src/models/visualization/flows/support/camel-component-default.service.ts(130,12): error TS2678: Type '"otherwise"' is not comparable to type 'keyof ProcessorDefinition'.
Error: [@kaoto/kaoto]: src/models/visualization/flows/support/camel-component-schema.service.ts(174,26): error TS2678: Type '"when"' is not comparable to type 'keyof ProcessorDefinition'.
Error: [@kaoto/kaoto]: src/models/visualization/flows/support/camel-component-schema.service.ts(175,26): error TS2678: Type '"otherwise"' is not comparable to type 'keyof ProcessorDefinition'.
Error: [@kaoto/kaoto]: src/models/visualization/flows/support/camel-component-schema.service.ts(184,[12](https://github.com/KaotoIO/kaoto/actions/runs/13281234951/job/37079865601?pr=2001#step:8:13)): error TS2678: Type '"onFallback"' is not comparable to type 'keyof ProcessorDefinition'.
Error: [@kaoto/kaoto]: src/models/visualization/flows/support/camel-component-schema.service.ts(190,12): error TS2678: Type '"whenSkipSendToEndpoint"' is not comparable to type 'keyof ProcessorDefinition'.

@lordrip lordrip added the on hold Issues or pull requests that are waiting for something label Feb 12, 2025
@lordrip
Copy link
Member

lordrip commented Feb 12, 2025

Considering that when and otherwise are no longer considered Processors, we need to rework the Catalog generator to accommodate this.

@lhein
Copy link
Contributor

lhein commented Feb 26, 2025

4.10.1 is coming soon. We should refacilitate this PR once that happens.

@lordrip lordrip added on hold Issues or pull requests that are waiting for something and removed on hold Issues or pull requests that are waiting for something labels Feb 27, 2025
@lordrip
Copy link
Member

lordrip commented Mar 20, 2025

Thanks @apupier for starting this. This PR is superseded by #2091

@lordrip lordrip closed this Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold Issues or pull requests that are waiting for something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants