Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore all function parameters option #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

natelong
Copy link

@natelong natelong commented Dec 4, 2012

Just whipped up a little patch to allow users to turn off function parameter testing, since it forces a lot of false positives, and isn't a bad practice in and of itself. Here's an example:

function (foo, bar) {
    console.log(bar);
}

You need to have foo declared so you can address bar whether or not you need foo.

Now, if you pass --ignore-all-parameters into the CLI, the unused function will ignore all unused function parameters.

Update after some discussion on earlier pull request

@defunctzombie
Copy link
Collaborator

This doesn't address some of the other concerns. Also, please collapse any commits into one before making a feature pull request :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants