Skip to content

Adjust window box for GTK HeaderBar #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Adjust window box for GTK HeaderBar #2

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
aac7612
Adjust window box for GTK HeaderBar
roym899 Oct 6, 2023
ea2e1ad
Fix comment
roym899 Oct 6, 2023
5229606
Check for gtk_extents and trust pos and geom otherwise
roym899 Oct 7, 2023
9df9c4d
Do opposite changes extent adjustments in _moveResizeWindow
roym899 Oct 8, 2023
2dbd98a
Clarify _net_extents correction in _moveResizeWindow
roym899 Oct 8, 2023
0219a6e
Fix mypy errors
roym899 Oct 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion src/pywinbox/_pywinbox_linux.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,29 @@ def _getWindowBox(handle: EwmhWindow) -> Box:
# https://stackoverflow.com/questions/12775136/get-window-position-and-size-in-python-with-xlib
geom = handle.xWindow.get_geometry()
pos = handle.root.translate_coords(handle.id, 0, 0)
return Box(pos.x, pos.y, geom.width, geom.height)

# check if application uses special title bar (a.k.a. GTK HeaderBar)
# see: https://docs.gtk.org/gtk4/class.HeaderBar.html
# if it has HeaderBar (e.g., gedit):
# top left will be top left including extra space (shadows?)
# in that case, we subtract gtk extents to the right box
# if it doesn't (e.g., gvim):
# top left will be top left of client window (i.e., excluding the title bar)
# in that case, we add the title bar to get the right box

_net_extents = handle._getNetFrameExtents()
if _net_extents and len(_net_extents) >= 4: # this means it has no GTK HeaderBar
x = pos.x - int(_net_extents[0])
y = pos.y - int(_net_extents[2])
w = geom.width + int(_net_extents[0]) + int(_net_extents[1])
h = geom.height + int(_net_extents[2]) + int(_net_extents[3])
else:
_gtk_extents = handle._getGtkFrameExtents()
x = pos.x + int(_gtk_extents[0])
y = pos.y + int(_gtk_extents[2])
w = geom.width - int(_gtk_extents[0]) - int(_gtk_extents[1])
h = geom.height - int(_gtk_extents[2]) - int(_gtk_extents[3])
return Box(x, y, w, h)


def _moveResizeWindow(handle: EwmhWindow, newBox: Box):
Expand Down