-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Rewrite kaggle kernels logs --follow to use SSE log stream
#999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+475
−128
Merged
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
1ac1a79
Rewrite `kaggle kernels logs --follow` to use SSE log stream
djherbis d231a70
Use correct END_OF_LOG sentinel for log stream
djherbis f92a3fe
Tests pass and changes are staged. The blob-fallback adaptation is co…
djherbis 77b07d5
Fix kernel logs stream URL to match midtier slug binding
djherbis cca1a80
Resolve merge conflicts with main
djherbis 91036fc
Align test_kernels_logs.py imports with main to clear conflicts
djherbis ff0df66
Merge branch 'main' into agent/herbison-20260505160932-d7e63a14
djherbis 4a8c226
Reconnect kernel log stream with dedup on transient drops
djherbis e2cf294
Silence reconnect warning on single transient drop
djherbis 6b03fbe
Render completed-session logs the same way as live streams
djherbis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current load balancer resets the connection every 3m, which means this log is going to stick out like a sore thumb in the average case.
Can we only print this message if we have repeat failures? ex. failures_without_progress > 1
That way a successful retry is hidden under the hood?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already addressed on this branch. The reconnect message is gated on
failures_without_progress > 1at src/kaggle/api/kaggle_api_extended.py:5407, so the routine ~3-minute LB reset (single failure, then successful retry) stays silent and only persistent trouble surfaces. Tests intests/test_kernels_logs.pycover both cases:test_kernels_logs_cli_follow_reconnects_and_dedupesasserts stderr is empty after a single drop, andtest_kernels_logs_cli_follow_reports_only_repeat_failuresasserts the warning appears exactly once on the second consecutive failure. All 21 tests pass.