Add support for formatting projections#1068
Merged
Merged
Conversation
The --format option now supports optional gcloud-style field selection (projections) by appending a comma-separated list of fields in parentheses to the format name. E.g., --format="json(ref,reward)". This also refactors CLI formatting to use a centralized print_results helper, reducing code duplication across commands. TAG=agy CONV=43417028-1d5e-4f83-b849-7a63186da785
rosbo
approved these changes
Jun 22, 2026
| return | ||
|
|
||
| output_fmt = self._get_output_format(csv_display, output_format) | ||
| all_fields = self.forum_topic_fields + self.forum_comment_fields |
Contributor
There was a problem hiding this comment.
Any reasons for not using self.print_results here?
Contributor
Author
There was a problem hiding this comment.
Just readability, simplicity. This handles the the complexity of multiple object formats coming back from the protos. Forcing use of the helper would add a lot of mapping code, or add complexity to the helper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The --format option now supports optional gcloud-style field selection (projections) by appending a comma-separated list of fields in parentheses to the format name. E.g., --format="json(ref,reward)".
This also refactors CLI formatting to use a centralized print_results helper, reducing code duplication across commands.
TAG=agy
CONV=43417028-1d5e-4f83-b849-7a63186da785