fix: remove noisy RDNA2 GEMV variant eprintln#532
Open
rakaarwaky wants to merge 1 commit into
Open
Conversation
The eprintln!(" RDNA2 GEMV variant: v{variant} ({name})") fires on
every GEMV kernel selection for gfx1030/gfx1031 (RDNA2), producing
hundreds of identical lines in serve.log and bench output. Remove it
— the variant info is already available via HIPFIRE_RDNA2_VARIANT env
var and the pre-compiled kernel cache directory name.
Kaden-Schutt
pushed a commit
that referenced
this pull request
Jul 18, 2026
Extract the intended delta from PR #532 onto the protected beta-derived branch. Remove the logging-only variant-name table along with the per-dispatch stderr line so the fix does not introduce new unused-variable warnings.
Kaden-Schutt
pushed a commit
that referenced
this pull request
Jul 21, 2026
Extract the intended delta from PR #532 onto the protected beta-derived branch. Remove the logging-only variant-name table along with the per-dispatch stderr line so the fix does not introduce new unused-variable warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
eprintln!(" RDNA2 GEMV variant: v{variant} ({name})")call ingemv_hfq4g256_for_arch(crates/rdna-compute/src/kernels.rs).Problem
On RDNA2 (gfx1030/gfx1031), every GEMV kernel selection prints this line to stderr:
Since a single decode step involves many GEMV calls, this produces hundreds of identical spam lines in
serve.logandhipfire benchoutput. The variant information is not actionable for users — it's only useful for kernel developers who can check the variant viaHIPFIRE_RDNA2_VARIANTenv var or the pre-compiled cache directory name.Testing
eprintln!string no longer appears in the compiled binary viastringshipfire bench qwen3.6-35b-a3b.mq2— no more RDNA2 GEMV variant spam in outputCloses #531