KUI-1467 CourseRound dropdown suffix solely based on funding type #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belanglos
force-pushed
the
issues/KUI-1467-courseRound-funding-suffix
branch
from
7706888 to
0a2781e
Compare
belanglos
force-pushed
the
issues/KUI-1467-courseRound-funding-suffix
branch
from
0a2781e to
ffb9b84
Compare
belanglos
requested review from
amirhossein-haerian,
axelbjo and
allazis
as code owners
allazis
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KUI-1467
The main change is in
useRoundUtils.jswhere the old suffix creation (containing special and default cases) is replaced by the new specification.Had a bit of a hard time navigating overthinking and "getting-it-done" ;-)
As far as I understand it, we're semantically actually mixing at least 3 things here. (1) Funding type, (2) round type and the (3) "text we want to show to the users". Possibly (2) and (3) actually are the same, but I'm not sure
round typedoes not also refer to something else semantically.VU(also confirmed by Susanne to still hold meaning) from the removedround_categorytoround_type_suffixand implementing the matching in the code.round_typein getFilteredData (exposed in context) is not used anymore, so I removed it and related variables.