Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct set alignment #86

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Correct set alignment #86

wants to merge 1 commit into from

Conversation

trevorb1
Copy link
Collaborator

In this PR I add functionality to define option data over any set. for example, to apply an emission limit and a capacity constraint to the same scenario data, you can define data like so:

PARAMETER,REGION,TECHNOLOGY,EMISSION,OPTION,YEAR,VALUE
TotalAnnualMaxCapacityInvestment,UTOPIA,IMPHCO1,,0,1990,999999999
TotalAnnualMaxCapacityInvestment,UTOPIA,IMPHCO1,,0,1991,999999999
TotalAnnualMaxCapacityInvestment,UTOPIA,IMPHCO1,,0,1992,999999999
...
AnnualEmissionLimit,UTOPIA,,NOX,0,,-50 
AnnualEmissionLimit,UTOPIA,,NOX,1,,-10000

While this bypasses the error described in issue #85, I am a little confused on how logic of handling data that is not defined over all sets (ie. AnnualEmissionLimit does not have an associated year in the provided example in the issue ticket). @HauHe was this just a mistake? Im not sure where to look to see if AnnualEmissionLimit is being applied correctly. I would suggest explicitly defining the year.

@HauHe
Copy link
Collaborator

HauHe commented Jan 19, 2025

Thanks a lot @trevorb1!
I will have a look at it tomorrow.
If I remember correctly I had left the year here on purpose, but I'm not 100% sure anymore what behaviour I expected when applying the data. Has been some time since I wrote the code. I'll let you know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants