Skip to content

Update build.sh to error-out on bad $BUILD or $BIN #1882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update build.sh to error-out on bad $BUILD or $BIN #1882

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63f532a
Update build.sh to abort on shell errors (`bash -e`)
wilsonjholmes Oct 5, 2024
a89a9b6
Update method of getting absolute paths to error out if they do not e…
wilsonjholmes Oct 5, 2024
686c6ab
Update comment to match implementation in build.sh: `realpath --canon…
wilsonjholmes Oct 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
#!/bin/bash -e

#
# KLayout Layout Viewer
Expand Down Expand Up @@ -595,10 +595,10 @@ mkdir -p $BUILD
. $(dirname $(which $0))/version.sh

# qmake needs absolute paths, so we get them now:
# OSX does not have `readlink -f` command. Use equivalent Perl script.
# OSX does not have `realpath --canonicalize-existing` command. Use equivalent Perl script.
if [ "$IS_MAC" = "no" ]; then
BUILD=`readlink -f $BUILD`
BIN=`readlink -f $BIN`
BUILD=`realpath --canonicalize-existing $BUILD`
BIN=`realpath --canonicalize-existing $BIN`
else
BUILD=`perl -MCwd -le 'print Cwd::abs_path(shift)' $BUILD`
BIN=`perl -MCwd -le 'print Cwd::abs_path(shift)' $BIN`
Expand Down