Task12 #813
Closed
Task12 #813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KFalcon2022
requested changes
Feb 4, 2025
| int[] basketsArray = new int[basketsAmount]; | ||
|
|
||
| for (int i = 0; i < basketsArray.length; i++) { | ||
| basketsArray[i] = Character.getNumericValue(baskets.charAt(i)); |
Owner
There was a problem hiding this comment.
Стоит ли вообще тратить ресурсы на конвертацию символов в числа? Какая разница, валидировать 0 и 1 или '0' и '1'?
| actionsAmount[i] += basketsArray[left] * (i - left); | ||
| } | ||
|
|
||
| for (int right = i + 1; right < actionsAmount.length; right++) { |
Owner
There was a problem hiding this comment.
есть четкое ощущение, что использование модуля (Math.abs()) избавит тебя от необходимости использовать два последовательных цикла и делить корзинки на правые и левые
KFalcon2022
reviewed
Feb 4, 2025
Author
|
Спасибо, исправила! |
KFalcon2022
approved these changes
Feb 17, 2025
Owner
KFalcon2022
left a comment
KFalcon2022
left a comment
There was a problem hiding this comment.
Мелкое замечание, задача зачтена
| if (!isValid(basketsArray[i])) { | ||
| return new int[]{}; | ||
| } | ||
| } |
Owner
There was a problem hiding this comment.
Логичнее было бы все, вместе с циклом, вынести в boolean-метод isValid(). И если результат false - возвращать пустой массив. Но текущий вариант тоже имеет право на жизнь
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.