Merged
Conversation
LeonMatthesKDAB
force-pushed
the
qtobject-trait
branch
6 times, most recently
from
fa1df00 to
86b25c8
Compare
LeonMatthesKDAB
changed the title
LeonMatthesKDAB
added
⬆️ feature
LeonMatthesKDAB
force-pushed
the
qtobject-trait
branch
from
86b25c8 to
2a8356c
Compare
LeonMatthesKDAB
force-pushed
the
qtobject-trait
branch
2 times, most recently
from
6656177 to
bb03423
Compare
Collaborator
|
Just needs rebasing, then looks good :-) |
Allows the type system to reason about the inner type of a given CXX-Qt QObject. Also cleanly documents where `rust` and `rust_mut` come from.
LeonMatthesKDAB
force-pushed
the
qtobject-trait
branch
from
bb03423 to
376d4ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This trait is automatically implemented on any
qobject::T. It currently exposes the inner Rust type for a given QObject.First step of implementing #550
This also requires us to split our macros into a cxx-qt-macro crate, as otherwise only exporting proc-macros is allowed.
We could now potentially move CxxQtThread into the cxx-qt crate now to remove the dependency on cxx-qt-lib.