-
Notifications
You must be signed in to change notification settings - Fork 88
qt-build-utils can invoke qmake when it is a script #1284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I only tested this so far on the "happy case" on Windows (that is to say: when using a qmake .bat wrapper). Will test on other platforms too. |
I marked as ready for review. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1284 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 75 75
Lines 12772 12772
=========================================
Hits 12772 12772 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f08b25c
to
e4ef4fa
Compare
e4ef4fa
to
031f080
Compare
In the refactored qt-build-utils, the change was a lot more straightforward. |
@ahayzen-kdab is this still on your radar? |
Ensure qmake is called either through
cmd
(Windows) orsh
(Linux/MacOS).The main change is this invocation. The rest of the code change is: