Skip to content

Add qobject extension trait #1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BenFordTytherington
Copy link
Collaborator

@BenFordTytherington BenFordTytherington commented Mar 14, 2025

  • cxx-qt-lib trait for additional qobject wrappers

Closes #562

The added methods are:

  • blockSignals
  • signalsBlocked
  • setObjectName
  • objectName
  • parent
  • setParent

@BenFordTytherington BenFordTytherington force-pushed the add-qobject-extension branch 2 times, most recently from da2aeeb to 627a8a6 Compare March 14, 2025 12:03
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d795722) to head (a47540d).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1226   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           73        73           
  Lines        12634     12634           
=========================================
  Hits         12634     12634           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BenFordTytherington BenFordTytherington force-pushed the add-qobject-extension branch 6 times, most recently from e0c231e to 65f097a Compare March 14, 2025 13:13
@BenFordTytherington BenFordTytherington force-pushed the add-qobject-extension branch 4 times, most recently from 85550c4 to 0a3410d Compare March 28, 2025 15:24
@BenFordTytherington BenFordTytherington marked this pull request as ready for review March 28, 2025 15:58
Copy link
Collaborator

@LeonMatthesKDAB LeonMatthesKDAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks, and some documentation is missing.

Otherwise looks good :)

@BenFordTytherington BenFordTytherington force-pushed the add-qobject-extension branch 2 times, most recently from 2f5dae6 to 0fc5b11 Compare April 7, 2025 16:06
@BenFordTytherington BenFordTytherington force-pushed the add-qobject-extension branch 2 times, most recently from 33bfa62 to a2275ef Compare May 2, 2025 15:32
- cxx-qt-lib trait for additional qobject wrappers
- adds blockSignals
- adds signalsBlocked
- adds setObjectName
- adds objectName
- adds parent
- adds setParent
@LeonMatthesKDAB LeonMatthesKDAB force-pushed the add-qobject-extension branch from a2275ef to a47540d Compare May 6, 2025 20:26
@LeonMatthesKDAB LeonMatthesKDAB enabled auto-merge (rebase) May 6, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Traits for CxxQtType/QtObject
3 participants