Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #889
Optimizes scan filtering when non-native filter(s) are combined with native filter(s), by favoring native scan filtering and moving non-native supported filters to flow filtering.
Take the following example:
This PR will optimize the scan by establishing a native filter for the
Filter.Service
andFilter.ServiceData
and having theFilter.Name.Prefix
filtering occur via flow operator.This optimization is only possible when a single
match
is specified (i.e. filters will not beOR
'd). This is because when there are multiple filtermatch
declarations, then it would be difficult to reliably determine which native filter was applied to know what "overlayed" filters should occur at the flow operator level. To illustrate this limitation, take the following example:Then, during a scan there isn't a clear way to filter at the flow operator:
As such, for these situations (more than one
match
with non-native filters): all filters will occur at the flow operator level.