added custom config dir argument

[flying-sheep]

to allow package maintainers to create and update global configs

[jcb91]

I'm afraid that this isn't really an appropriate place to put this functionality, as the _compat modules are intended to be an exact API copy of notebook 4.2. As a result, this will have to go into downstream functions/classes...

[flying-sheep]

this file uses the functions.

what other functions can it use that allow configuring the config file location?

[jcb91]

Well, there are no ready-made functions, I guess, which I admit is frustrating. Might be worth submitting an issue/PR to upstream notebook?

But, the use case you point to in src/jupyter_contrib_nbextensions/install.py would use this only as part of calls to _get_config_dir (which is easily wrapped), toggle_serverextension_python (which is easily mimicked), install_nbextension_python (which doesn't actually write to any config anyway), and uninstall_nbextension_python (which, as it only seeks to remove the nbextension's require url from the config, could be ignored in our case, or wrapped). I'll wrap up a PR to src/jupyter_contrib_nbextensions/install.py to show what I mean...

[flying-sheep]

OK, please cc me 😃

[flying-sheep]

hi @jcb91, any news?

[jcb91]

apologies @flying-sheep I've been a bit preoccupied by house repairs for a couple of weeks, and in the last week my macbook's decided to throw a fit and use 80% cu time on kernel_task for no reason (joy!).

[flying-sheep]

no problem, good luck with that!