fix(lint): resolve errcheck violations for deferred resource closures#8
Open
i-naman wants to merge 1 commit into
Open
fix(lint): resolve errcheck violations for deferred resource closures#8i-naman wants to merge 1 commit into
i-naman wants to merge 1 commit into
Conversation
Wrapped all deferred 'stream.Close()', 'file.Close()', 'rows.Close()', and 'conn.Close()' calls in error-handling closures to stop swallowing teardown errors and resolve ~75 golangci-lint errcheck violations.
neerajvipparla
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses ~75
errcheckviolations across the codebase where errors returned by deferredClose()calls were being silently ignored.While deferred closures are standard practice, completely ignoring their return values can mask failures during resource teardown (such as failing to flush buffers, release file locks, or close network streams cleanly).
Changes
stream.Close()calls inAVC,NodeSelection,Sequencer, etc.rows.Close()anddb.Close()calls inDB_OPsandseedhelper.file.Close()calls intransfer,node, andDB_OPs.conn.Close()calls for database and network connections.Impact
This is a non-breaking change. It solely adds visibility into resource leakages and teardown failures by wrapping the closures in anonymous functions to properly catch and log any errors.