Feature/sc

.gitignore

@@ -46,4 +46,26 @@ __debug_bin
 vendor/
 
 # Internal team references
-docs/SONARQUBE_SETUP_GUIDE.md
+docs/SONARQUBE_SETUP_GUIDE.md
+ADR-001-JMDT-Native-EVM-Smart-Contracts.docx
+jmdn.yaml
+contract_storage_pebble/000004.log
+*.log
+*.logs
+*.db
+*.db-wal
+contract_storage_pebble/CURRENT
+contract_storage_pebble/LOCK
+contract_storage_pebble/MANIFEST-000001
+contract_storage_pebble/MANIFEST-000005
+contract_storage_pebble/*
+SmartContract/artifacts/*
+SmartContract/artifacts/HelloWorld.json
+/SmartContract/artifacts
+SmartContract/artifacts/HelloWorld.json
+docs/refactor-contractDBOps.md
+internal/WAL/*
+docs/ADR-001-code-review.md
+AVC/BLS/Router/config/bls.json
+AVC/BuddyNodes/MessagePassing/BLS_Signer/config/bls.json
+AVC/BuddyNodes/MessagePassing/BLS_Verifier/config/bls.json

AVC/BFT/bft/logger.go

@@ -8,9 +8,9 @@ import (
 
 // Zero allocation logger - its already allocated in the asynclogger
 func logger() *ion.Ion {
-	logger, err := log.NewAsyncLogger().Get().NamedLogger(log.BFT, "")
+	logInstance, err := log.NewAsyncLogger().Get().NamedLogger(log.BFT, "")
 	if err != nil {
 		return nil
 	}
-	return logger.NamedLogger
+	return logInstance.GetNamedLogger()
 }

AVC/BFT/network/libp2p_setup.go

@@ -7,6 +7,7 @@ import (
 	"context"
 	"fmt"
 
+	"github.com/JupiterMetaLabs/ion"
 	"github.com/libp2p/go-libp2p"
 	pubsub "github.com/libp2p/go-libp2p-pubsub"
 	"github.com/libp2p/go-libp2p/core/host"
@@ -35,58 +36,58 @@ func SetupLibp2pHost(ctx context.Context, port int) (host.Host, *pubsub.PubSub,
 		return nil, nil, fmt.Errorf("failed to create gossipsub: %w", err)
 	}
 
-	fmt.Printf("✅ libp2p host created\n")
-	fmt.Printf("   Peer ID: %s\n", h.ID())
-	fmt.Printf("   Listening on: %s\n", listenAddr)
+	logger().Info(context.Background(), "✅ libp2p host created\n")
+	logger().Info(context.Background(), "   Peer ID: %s", h.ID())
+	logger().Info(context.Background(), "   Listening on: %s", listenAddr)
 
 	return h, ps, nil
 }
 
 // ConnectToPeers connects to bootstrap/peer nodes
 func ConnectToPeers(ctx context.Context, h host.Host, peerAddrs []string) error {
 	if len(peerAddrs) == 0 {
-		fmt.Println("⚠️  No peers to connect to")
+		logger().Warn(context.Background(), "No peers to connect to")
 		return nil
 	}
 
-	fmt.Printf("🔗 Connecting to %d peers...\n", len(peerAddrs))
+	logger().Info(context.Background(), "🔗 Connecting to %d peers...", len(peerAddrs))
 
 	for _, addrStr := range peerAddrs {
 		// Parse multiaddr
 		maddr, err := multiaddr.NewMultiaddr(addrStr)
 		if err != nil {
-			fmt.Printf("❌ Invalid peer address %s: %v\n", addrStr, err)
+			logger().Info(context.Background(), "❌ Invalid peer address %s: %v", addrStr, err)
 			continue
 		}
 
 		// Extract peer info
 		peerInfo, err := peer.AddrInfoFromP2pAddr(maddr)
 		if err != nil {
-			fmt.Printf("❌ Failed to parse peer info from %s: %v\n", addrStr, err)
+			logger().Info(context.Background(), "❌ Failed to parse peer info from %s: %v", addrStr, err)
 			continue
 		}
 
 		// Check if this is a self-connection attempt
 		if peerInfo.ID == h.ID() {
-			fmt.Printf("🚫 Skipping self-connection attempt: %s\n", addrStr)
+			logger().Info(context.Background(), "🚫 Skipping self-connection attempt: %s", addrStr)
 			continue
 		}
 
 		// Connect
 		if err := h.Connect(ctx, *peerInfo); err != nil {
-			fmt.Printf("❌ Failed to connect to %s: %v\n", peerInfo.ID, err)
+			logger().Info(context.Background(), "❌ Failed to connect to %s: %v", peerInfo.ID, err)
 			continue
 		}
 
-		fmt.Printf("✅ Connected to peer: %s\n", peerInfo.ID)
+		logger().Info(context.Background(), "✅ Connected to peer: %s", peerInfo.ID)
 	}
 
 	return nil
 }
 
 // SetupSimpleNetwork creates a local test network
 func SetupSimpleNetwork(ctx context.Context, numNodes int, startPort int) ([]host.Host, []*pubsub.PubSub, error) {
-	fmt.Printf("🚀 Setting up local test network with %d nodes\n", numNodes)
+	logger().Info(context.Background(), "🚀 Setting up local test network with %d nodes", numNodes)
 
 	hosts := make([]host.Host, numNodes)
 	pubsubs := make([]*pubsub.PubSub, numNodes)
@@ -102,7 +103,7 @@ func SetupSimpleNetwork(ctx context.Context, numNodes int, startPort int) ([]hos
 	}
 
 	// Connect them all together (full mesh for testing)
-	fmt.Println("\n🔗 Connecting nodes in full mesh...")
+	logger().Info(context.Background(), "Connecting nodes in full mesh")
 	for i := 0; i < numNodes; i++ {
 		for j := i + 1; j < numNodes; j++ {
 			// Connect i to j
@@ -112,11 +113,11 @@ func SetupSimpleNetwork(ctx context.Context, numNodes int, startPort int) ([]hos
 			}
 
 			if err := hosts[i].Connect(ctx, peerInfo); err != nil {
-				fmt.Printf("⚠️  Failed to connect node %d to node %d: %v\n", i, j, err)
+				logger().Info(context.Background(), "⚠️  Failed to connect node %d to node %d: %v", i, j, err)
 			}
 		}
 	}
 
-	fmt.Printf("\n✅ Network setup complete! %d nodes connected\n", numNodes)
+	logger().Info(context.Background(), "\n✅ Network setup complete! %d nodes connected", numNodes)
 	return hosts, pubsubs, nil
 }

AVC/BFT/network/logger.go

@@ -0,0 +1,16 @@
+package network
+
+import (
+	log "gossipnode/logging"
+
+	"github.com/JupiterMetaLabs/ion"
+)
+
+// Zero allocation logger - its already allocated in the asynclogger
+func logger() *ion.Ion {
+	logInstance, err := log.NewAsyncLogger().Get().NamedLogger(log.BFTNetwork, "")
+	if err != nil {
+		return nil
+	}
+	return logInstance.GetNamedLogger()
+}

AVC/BuddyNodes/DataLayer/CRDTLayer.go

@@ -8,7 +8,9 @@ import (
 
 	"gossipnode/AVC/BuddyNodes/Types"
 	"gossipnode/crdt"
+	log "gossipnode/logging"
 
+	"github.com/JupiterMetaLabs/ion"
 	"github.com/libp2p/go-libp2p/core/peer"
 )
 
@@ -120,7 +122,7 @@ func SyncAllNodes(ctx context.Context, nodes map[string]*Types.Controller) error
 		for j := i + 1; j < len(nodeIDs); j++ {
 			node1ID := nodeIDs[i]
 			node2ID := nodeIDs[j]
-			fmt.Println("Syncing", node1ID, "with", node2ID)
+			logger(log.CRDTLayer).Debug(context.Background(), "Syncing CRDT nodes", ion.String("node1", node1ID), ion.String("node2", node2ID))
 			if err := SyncWithNode(ctx, nodes[node1ID], nodes[node2ID], node1ID, node2ID); err != nil {
 				return fmt.Errorf("failed to sync %s with %s: %v", node1ID, node2ID, err)
 			}
@@ -140,3 +142,13 @@ func GetCRDTState(ctx context.Context, controller *Types.Controller) map[string]
 func applyMergedCRDT(engine *crdt.Engine, key string, crdt crdt.CRDT) {
 	engine.ApplyMergedCRDT(key, crdt)
 }
+
+
+// logger returns the ion logger instance for CRDT layer
+func logger(namedLogger string) *ion.Ion {
+	logInstance, err := log.NewAsyncLogger().Get().NamedLogger(namedLogger, "")
+	if err != nil {
+		return nil
+	}
+	return logInstance.GetNamedLogger()
+}

AVC/BuddyNodes/MessagePassing/BuddyNodeStream.go

@@ -62,7 +62,7 @@ func (StructBuddyNode *StructBuddyNode) HandleBuddyNodesMessageStream(host host.
 	}
 
 	// Record trace span and close it
-	streamSpanCtx, streamSpan := logger().NamedLogger.Tracer("MessagePassing").Start(spanCtx, "MessagePassing.HandleBuddyNodesMessageStream")
+	streamSpanCtx, streamSpan := logger().Tracer("MessagePassing").Start(spanCtx, "MessagePassing.HandleBuddyNodesMessageStream")
 	defer streamSpan.End()
 
 	startTime := time.Now().UTC()
@@ -79,8 +79,7 @@ func (StructBuddyNode *StructBuddyNode) HandleBuddyNodesMessageStream(host host.
 		streamSpan.SetAttributes(attribute.String("status", "read_error"))
 		duration := time.Since(startTime).Seconds()
 		streamSpan.SetAttributes(attribute.Float64("duration", duration))
-		logger().NamedLogger.Error(streamSpanCtx, "Error reading message from peer",
-			err,
+		logger().Error(streamSpanCtx, "Error reading message from peer", err,
 			ion.String("remote_peer_id", remotePeer.String()),
 			ion.String("message", msg),
 			ion.String("created_at", time.Now().UTC().Format(time.RFC3339)),
@@ -95,7 +94,7 @@ func (StructBuddyNode *StructBuddyNode) HandleBuddyNodesMessageStream(host host.
 
 	message := AVCStruct.NewMessageBuilder(nil).DeferenceMessage(msg)
 
-	logger().NamedLogger.Info(streamSpanCtx, "Received buddy message from peer",
+	logger().Info(streamSpanCtx, "Received buddy message from peer",
 		ion.String("remote_peer_id", remotePeer.String()),
 		ion.String("message", msg),
 		ion.String("created_at", time.Now().UTC().Format(time.RFC3339)),
@@ -110,7 +109,7 @@ func (StructBuddyNode *StructBuddyNode) HandleBuddyNodesMessageStream(host host.
 		streamSpan.SetAttributes(attribute.String("status", "parse_failed"))
 		duration := time.Since(startTime).Seconds()
 		streamSpan.SetAttributes(attribute.Float64("duration", duration))
-		logger().NamedLogger.Error(streamSpanCtx, "Failed to parse message - malformed JSON or invalid structure",
+		logger().Error(streamSpanCtx, "Failed to parse message - malformed JSON or invalid structure",
 			errors.New("failed to parse message"),
 			ion.String("remote_peer_id", remotePeer.String()),
 			ion.String("raw_message", msg),
@@ -129,7 +128,7 @@ func (StructBuddyNode *StructBuddyNode) HandleBuddyNodesMessageStream(host host.
 		streamSpan.SetAttributes(attribute.String("status", "nil_ack"))
 		duration := time.Since(startTime).Seconds()
 		streamSpan.SetAttributes(attribute.Float64("duration", duration))
-		logger().NamedLogger.Error(streamSpanCtx, "Received message with nil ACK",
+		logger().Error(streamSpanCtx, "Received message with nil ACK",
 			errors.New("received message with nil ACK"),
 			ion.String("remote_peer_id", remotePeer.String()),
 			ion.String("raw_message", msg),
@@ -163,7 +162,7 @@ func (StructBuddyNode *StructBuddyNode) HandleBuddyNodesMessageStream(host host.
 	if err := Router.Router(gossipMessage); err != nil {
 		streamSpan.RecordError(err)
 		streamSpan.SetAttributes(attribute.String("status", "router_failed"))
-		logger().NamedLogger.Error(streamSpanCtx, "Failed to handle message via service layer",
+		logger().Error(streamSpanCtx, "Failed to handle message via service layer",
 			err,
 			ion.String("remote_peer_id", remotePeer.String()),
 			ion.String("message", msg),
@@ -190,7 +189,7 @@ func (StructBuddyNode *StructBuddyNode) HandleBuddyNodesMessageStream(host host.
 // handleStartPubSub handles the StartPubSub message type with direct logic
 func (StructBuddyNode *StructBuddyNode) handleStartPubSub(spanCtx context.Context, s network.Stream) {
 	// Record trace span and close it
-	startPubSubSpanCtx, startPubSubSpan := logger().NamedLogger.Tracer("MessagePassing").Start(spanCtx, "MessagePassing.handleStartPubSub")
+	startPubSubSpanCtx, startPubSubSpan := logger().Tracer("MessagePassing").Start(spanCtx, "MessagePassing.handleStartPubSub")
 	defer startPubSubSpan.End()
 
 	startTime := time.Now().UTC()
@@ -215,7 +214,7 @@ func (StructBuddyNode *StructBuddyNode) handleStartPubSub(spanCtx context.Contex
 			startPubSubSpan.SetAttributes(attribute.String("status", "marshal_failed"))
 			duration := time.Since(startTime).Seconds()
 			startPubSubSpan.SetAttributes(attribute.Float64("duration", duration))
-			logger().NamedLogger.Error(startPubSubSpanCtx, "Failed to marshal ACK message",
+			logger().Error(startPubSubSpanCtx, "Failed to marshal ACK message",
 				err,
 				ion.String("remote_peer_id", remotePeer.String()),
 				ion.String("ack_type", "ACK_TRUE"),
@@ -232,7 +231,7 @@ func (StructBuddyNode *StructBuddyNode) handleStartPubSub(spanCtx context.Contex
 			startPubSubSpan.SetAttributes(attribute.String("status", "send_failed"))
 			duration := time.Since(startTime).Seconds()
 			startPubSubSpan.SetAttributes(attribute.Float64("duration", duration))
-			logger().NamedLogger.Error(startPubSubSpanCtx, "Failed to send ACK to peer",
+			logger().Error(startPubSubSpanCtx, "Failed to send ACK to peer",
 				err,
 				ion.String("remote_peer_id", remotePeer.String()),
 				ion.String("ack_type", "ACK_TRUE"),
@@ -244,7 +243,7 @@ func (StructBuddyNode *StructBuddyNode) handleStartPubSub(spanCtx context.Contex
 		} else {
 			duration := time.Since(startTime).Seconds()
 			startPubSubSpan.SetAttributes(attribute.Float64("duration", duration), attribute.String("status", "success"), attribute.String("ack_sent", "ACK_TRUE"))
-			logger().NamedLogger.Info(startPubSubSpanCtx, "Sent ACK_TRUE to peer for pubsub subscription",
+			logger().Info(startPubSubSpanCtx, "Sent ACK_TRUE to peer for pubsub subscription",
 				ion.String("remote_peer_id", remotePeer.String()),
 				ion.String("ack_type", "ACK_TRUE"),
 				ion.Float64("duration", duration),
@@ -271,7 +270,7 @@ func (StructBuddyNode *StructBuddyNode) handleStartPubSub(spanCtx context.Contex
 			startPubSubSpan.SetAttributes(attribute.String("status", "marshal_failed"))
 			duration := time.Since(startTime).Seconds()
 			startPubSubSpan.SetAttributes(attribute.Float64("duration", duration))
-			logger().NamedLogger.Error(startPubSubSpanCtx, "Failed to marshal ACK message",
+			logger().Error(startPubSubSpanCtx, "Failed to marshal ACK message",
 				err,
 				ion.String("remote_peer_id", remotePeer.String()),
 				ion.String("ack_type", "ACK_FALSE"),
@@ -288,7 +287,7 @@ func (StructBuddyNode *StructBuddyNode) handleStartPubSub(spanCtx context.Contex
 			startPubSubSpan.SetAttributes(attribute.String("status", "send_failed"))
 			duration := time.Since(startTime).Seconds()
 			startPubSubSpan.SetAttributes(attribute.Float64("duration", duration))
-			logger().NamedLogger.Error(startPubSubSpanCtx, "Failed to send ACK to peer",
+			logger().Error(startPubSubSpanCtx, "Failed to send ACK to peer",
 				err,
 				ion.String("remote_peer_id", remotePeer.String()),
 				ion.String("ack_type", "ACK_FALSE"),
@@ -300,7 +299,7 @@ func (StructBuddyNode *StructBuddyNode) handleStartPubSub(spanCtx context.Contex
 		} else {
 			duration := time.Since(startTime).Seconds()
 			startPubSubSpan.SetAttributes(attribute.Float64("duration", duration), attribute.String("status", "success"), attribute.String("ack_sent", "ACK_FALSE"))
-			logger().NamedLogger.Info(startPubSubSpanCtx, "Sent ACK_FALSE to peer - node not ready for pubsub",
+			logger().Info(startPubSubSpanCtx, "Sent ACK_FALSE to peer - node not ready for pubsub",
 				ion.String("remote_peer_id", remotePeer.String()),
 				ion.String("ack_type", "ACK_FALSE"),
 				ion.Float64("duration", duration),
@@ -316,7 +315,7 @@ func (StructBuddyNode *StructBuddyNode) handleStartPubSub(spanCtx context.Contex
 // handleSubscriptionResponse handles subscription response messages
 func (StructBuddyNode *StructBuddyNode) handleSubscriptionResponse(spanCtx context.Context, s network.Stream, message *AVCStruct.Message) {
 	// Record trace span and close it
-	subResponseSpanCtx, subResponseSpan := logger().NamedLogger.Tracer("MessagePassing").Start(spanCtx, "MessagePassing.handleSubscriptionResponse")
+	subResponseSpanCtx, subResponseSpan := logger().Tracer("MessagePassing").Start(spanCtx, "MessagePassing.handleSubscriptionResponse")
 	defer subResponseSpan.End()
 
 	startTime := time.Now().UTC()
@@ -331,7 +330,7 @@ func (StructBuddyNode *StructBuddyNode) handleSubscriptionResponse(spanCtx conte
 			subResponseSpan.SetAttributes(attribute.String("status", "ack_true"))
 			if StructBuddyNode.BuddyNode.ResponseHandler != nil {
 				StructBuddyNode.BuddyNode.ResponseHandler.HandleResponse(remotePeer, true, "main")
-				logger().NamedLogger.Info(subResponseSpanCtx, "Handled ACK_TRUE subscription response",
+				logger().Info(subResponseSpanCtx, "Handled ACK_TRUE subscription response",
 					ion.String("remote_peer_id", remotePeer.String()),
 					ion.String("ack_status", "ACK_TRUE"),
 					ion.String("created_at", time.Now().UTC().Format(time.RFC3339)),
@@ -344,7 +343,7 @@ func (StructBuddyNode *StructBuddyNode) handleSubscriptionResponse(spanCtx conte
 			subResponseSpan.SetAttributes(attribute.String("status", "ack_false"))
 			if StructBuddyNode.BuddyNode.ResponseHandler != nil {
 				StructBuddyNode.BuddyNode.ResponseHandler.HandleResponse(remotePeer, false, "main")
-				logger().NamedLogger.Info(subResponseSpanCtx, "Handled ACK_FALSE subscription response",
+				logger().Info(subResponseSpanCtx, "Handled ACK_FALSE subscription response",
 					ion.String("remote_peer_id", remotePeer.String()),
 					ion.String("ack_status", "ACK_FALSE"),
 					ion.String("created_at", time.Now().UTC().Format(time.RFC3339)),
@@ -358,7 +357,7 @@ func (StructBuddyNode *StructBuddyNode) handleSubscriptionResponse(spanCtx conte
 			subResponseSpan.SetAttributes(attribute.String("status", "unknown_ack_status"))
 			duration := time.Since(startTime).Seconds()
 			subResponseSpan.SetAttributes(attribute.Float64("duration", duration))
-			logger().NamedLogger.Error(subResponseSpanCtx, "Unknown status in ACK_Message",
+			logger().Error(subResponseSpanCtx, "Unknown status in ACK_Message",
 				errors.New("unknown status in ACK_Message"),
 				ion.String("remote_peer_id", remotePeer.String()),
 				ion.String("ack_status", ackStatus),
@@ -373,7 +372,7 @@ func (StructBuddyNode *StructBuddyNode) handleSubscriptionResponse(spanCtx conte
 		subResponseSpan.SetAttributes(attribute.String("status", "nil_ack"))
 		duration := time.Since(startTime).Seconds()
 		subResponseSpan.SetAttributes(attribute.Float64("duration", duration))
-		logger().NamedLogger.Error(subResponseSpanCtx, "Unknown message type received from peer",
+		logger().Error(subResponseSpanCtx, "Unknown message type received from peer",
 			errors.New("unknown message type received"),
 			ion.String("remote_peer_id", remotePeer.String()),
 			ion.String("created_at", time.Now().UTC().Format(time.RFC3339)),
@@ -387,7 +386,7 @@ func (StructBuddyNode *StructBuddyNode) handleSubscriptionResponse(spanCtx conte
 // sendACKResponse sends ACK response based on success/failure
 func (StructBuddyNode *StructBuddyNode) sendACKResponse(spanCtx context.Context, s network.Stream, success bool, stage string) {
 	// Record trace span and close it
-	ackResponseSpanCtx, ackResponseSpan := logger().NamedLogger.Tracer("MessagePassing").Start(spanCtx, "MessagePassing.sendACKResponse")
+	ackResponseSpanCtx, ackResponseSpan := logger().Tracer("MessagePassing").Start(spanCtx, "MessagePassing.sendACKResponse")
 	defer ackResponseSpan.End()
 
 	startTime := time.Now().UTC()
@@ -423,7 +422,7 @@ func (StructBuddyNode *StructBuddyNode) sendACKResponse(spanCtx context.Context,
 		ackResponseSpan.SetAttributes(attribute.String("status", "marshal_failed"))
 		duration := time.Since(startTime).Seconds()
 		ackResponseSpan.SetAttributes(attribute.Float64("duration", duration))
-		logger().NamedLogger.Error(ackResponseSpanCtx, "Failed to marshal ACK response message",
+		logger().Error(ackResponseSpanCtx, "Failed to marshal ACK response message",
 			err,
 			ion.String("remote_peer_id", remotePeer.String()),
 			ion.String("ack_type", ackType),
@@ -441,7 +440,7 @@ func (StructBuddyNode *StructBuddyNode) sendACKResponse(spanCtx context.Context,
 		ackResponseSpan.SetAttributes(attribute.String("status", "send_failed"))
 		duration := time.Since(startTime).Seconds()
 		ackResponseSpan.SetAttributes(attribute.Float64("duration", duration))
-		logger().NamedLogger.Error(ackResponseSpanCtx, "Failed to send ACK response to peer",
+		logger().Error(ackResponseSpanCtx, "Failed to send ACK response to peer",
 			err,
 			ion.String("remote_peer_id", remotePeer.String()),
 			ion.String("ack_type", ackType),
@@ -454,7 +453,7 @@ func (StructBuddyNode *StructBuddyNode) sendACKResponse(spanCtx context.Context,
 	} else {
 		duration := time.Since(startTime).Seconds()
 		ackResponseSpan.SetAttributes(attribute.Float64("duration", duration), attribute.String("status", "success"))
-		logger().NamedLogger.Info(ackResponseSpanCtx, "Sent ACK response to peer",
+		logger().Info(ackResponseSpanCtx, "Sent ACK response to peer",
 			ion.String("remote_peer_id", remotePeer.String()),
 			ion.String("ack_type", ackType),
 			ion.String("stage", stage),