Add Image Download Support (New Download Type) #2313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add IMAGE type to DownloadType enum - Implement ImageSelectionPage with quality selector (Low, Medium, High, HD, Original) - Add ImageQuality enum with YouTube thumbnail quality mappings - Implement pickBestImageUrl() with HEAD request probing for quality fallback - Add automatic quality fallback: ORIGINAL → HD → HIGH → MEDIUM → LOW - Fix filename generation (clean format: videoId_quality.ext) - Extract file extension from Content-Type header - Add retry logic (2 attempts) for transient network failures - Add timeout configuration (5s for HEAD, 30s for download) - Add MediaScannerConnection for gallery integration - Add Task.TypeInfo.ImageDownload for image download tasks - Update DownloaderV2 with downloadImages() and downloadImage() - Add downloadImageFromUrl() with proper error handling - Add getPicturesSealFile() helper to save to /Pictures/Seal/ - Add image-related string resources - Fix ErrorPage crash by handling FetchImages action Closes: Image download feature request
Author
This feature request was originally raised in issue #2300, and this PR fully implements the requested image download support (thumbnail + playlist cover + quality selection). Implementation has been tested on Android 15, and all existing functionality (audio/video/playlist) works as before without regressions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new IMAGE download type to Seal, allowing users to download video thumbnails and playlist covers at various quality levels.
Features Added
1. New Download Type: IMAGE
2. ImageSelectionPage UI
3. Smart Quality Selection
pickBestImageUrl()with HTTP HEAD request probing4. Robust Download Implementation
image/*)<videoId>_<quality>.<ext>5. File Management
/Pictures/Seal/directoryTechnical Details
Modified Files
PreferenceUtil.kt- Added IMAGE enum valueDownloadDialogViewModel.kt- Added ImageQuality enum and state managementImageSelectionPage.kt- New UI component (327 lines)DownloaderV2.kt- Image download orchestrationDownloadUtil.kt- pickBestImageUrl() and downloadImageFromUrl()FileUtil.kt- getPicturesSealFile() helperTask.kt- ImageDownload TypeInfoDownloadDialogV2.kt- Image type routing and error handlingstrings.xml- Image-related stringsBug Fixes
Testing
Tested with real YouTube thumbnails:
Checklist