two bugs i think... #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 29, 2015 09:36
This call resulted in a double fclose(), when the main routine later on does the same. Seems, the caller of yangFileParse 'owns' the FILE pointer, so remove this one.
The following yang would incorrectly compile the 'gen-foo' template at
the same level as 'module'
module unit-test {
...
grouping ut-group1 {
call gen-foo($help = "Test foo", $hidden = "internal");
}
}
template gen-foo ($help, $mandatory) {
leaf foo {
help $help;
if ($mandatory) {
mandatory $mandatory;
}
}
}
Previously it was instantiated under the 'feature' template, like
this.
stylesheet {
template "/features" {
module {
...
}
template "gen-leaf {}
}
}
It needed to be at the same level as '/features'
stylesheet {
template "/features" {
module {
}
}
template "gen-leaf {}
}
otherwise xsltproc barfs.
compilation error: file foo.xslt line 49 element template
element template only allowed as child of stylesheet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Phil,
Don't know how this works... but can you look to see if these are valid changes?
thanks
wing