Change the appareance of some keys #896
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
The debug APK is at the bottom of this page: https://github.com/Julow/Unexpected-Keyboard/actions/runs/13219276891 |
Keys can be made darker or dimmer individually in layouts. This is done by setting the new 'role' attributes. Roles are "normal", "action" and "space_bar". The "action" role is intended to be used for keys like shift, backspace and other keys from the bottom row. Themes and special layouts are updated.
Julow
force-pushed
the
key-appearance-roles
branch
from
18f43de to
0ae2b73
Compare
Merged
Contributor
|
This PR has been left open for almost 5 months, are there any plans on merging it? If not perhaps it should be closed. Other PRs are in a similar situation. For example the Housekeeping one by Haley should be closed as you don't plan on merging that one. |
Owner
Author
|
PRs tend to stay open for a long time because maintainer time is limited. This PR was opened approximately 10 maintainer days ago and is part of a larger plan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the colors of the bottom row keys and of the shift and delete keys. The intention is to make the keyboard feel less complicated. I hope this can make the keyboard more readable by making some keys easier to ignore.
Feedback welcome.
Here's how it looks:
