Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the Heartbeat pulse process for garage door #377

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tipi85
Copy link
Contributor

@tipi85 tipi85 commented Feb 24, 2024

In class FrameStatusRequestRequest, FPI1=254 creates an error for garage door ( opening device )
With FPI1=0, the error is gone and other equipements are reporting correctly.

In class FrameStatusRequestRequest, FPI1=254 creates an error with garage door. With FPI1=0, the error is gone and other equipement are still reporting.
Update frame_status_request_test.py
@tipi85 tipi85 closed this Feb 24, 2024
@tipi85 tipi85 reopened this Feb 24, 2024
Correct CRC in test reply due to frame content changed
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.95%. Comparing base (6cb8633) to head (6fc9380).
Report is 3 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #377   +/-   ##
=======================================
  Coverage   78.95%   78.95%           
=======================================
  Files          78       78           
  Lines        3649     3649           
=======================================
  Hits         2881     2881           
  Misses        768      768           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tipi85
Copy link
Contributor Author

tipi85 commented Feb 26, 2024

fixes : #377

@pawlizio
Copy link
Collaborator

Have you tested this modification with forfunctional parameter also for other device types?
The idea of the FPI1 and FPI2 in this request is, that you receive the status of functional parameter as well. If you set FPI1 to 0, the reply will only include the main parameter:
image

Logic of FPI1/FPI2 is discribed here:
image

For example Dual Roller Shutter use functional parameter 1 for the position of the upper cover and functional parameter 2 for the lower one.

However I do not understand why it is set to 254 currently, as this is in binary 11111110 (big endian). In the specification only the first 3 functional parameters are used on the list of different actualy types. In this case a reply for them would be enough, so FPI1 with value 11100000 should be OK, but this is not 254 but 224
image

Can you test if you have problems with your garage doors with 224?

@tipi85
Copy link
Contributor Author

tipi85 commented Mar 2, 2024

Indeed I reduced it at first to 224 (11100000) then 128 ( 10000000 ) but the effect was unchanged. Unfortunately all my devices are not using FP1 to 3 so I cannot evaluate if this as an effect on the reporting of the other parameters. I always got the same logs :
current_position_fp1="UNKNOWN" current_position_fp2="UNKNOWN" current_position_fp3="UNKNOWN" current_position_fp4="UNKNOWN"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants