-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct the Heartbeat pulse process for garage door #377
base: master
Are you sure you want to change the base?
Conversation
In class FrameStatusRequestRequest, FPI1=254 creates an error with garage door. With FPI1=0, the error is gone and other equipement are still reporting.
Update frame_status_request_test.py
Correct test
Correct CRC in test reply due to frame content changed
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #377 +/- ##
=======================================
Coverage 78.95% 78.95%
=======================================
Files 78 78
Lines 3649 3649
=======================================
Hits 2881 2881
Misses 768 768 ☔ View full report in Codecov by Sentry. |
fixes : #377 |
Indeed I reduced it at first to 224 (11100000) then 128 ( 10000000 ) but the effect was unchanged. Unfortunately all my devices are not using FP1 to 3 so I cannot evaluate if this as an effect on the reporting of the other parameters. I always got the same logs : |
In class FrameStatusRequestRequest, FPI1=254 creates an error for garage door ( opening device )
With FPI1=0, the error is gone and other equipements are reporting correctly.