Valibot support #31
Draft
Valibot support #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrunnerLivio
force-pushed
the
feat/valibot-support
branch
from
468fae0 to
bf7484a
Compare
Julien-R44
reviewed
Jan 4, 2025
There was a problem hiding this comment.
PR looks perfect to me. Thanks a lot!
Agree to wait for version 1.0.0 of Valibot. If you're not in a rush and don't mind, I think it's better this way, it willl save us from having to release a major update if they make any breaking changes before their official release
Thanks again!
| @@ -64,6 +64,7 @@ | |||
| "checks": "pnpm lint && pnpm typecheck" | |||
| }, | |||
| "peerDependencies": { | |||
| "valibot": "^1.0.0", | |||
There was a problem hiding this comment.
Should also be added to peerDependenciesMeta as an optional peer dep
BrunnerLivio
force-pushed
the
feat/valibot-support
branch
from
bf7484a to
8f04430
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #29
This PR is set up as a draft because I would encourage waiting a bit longer to merge this until Valibot hits 1.x.x.