Update readbytes! to avoid using internal API of IOBuffer less #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this claims to be supported for all GenericIOBuffer, but Base only defines this function on a normal IOBuffer for which `pointer(data)` is contiguous space
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1148 +/- ##
==========================================
- Coverage 82.67% 82.62% -0.05%
==========================================
Files 32 32
Lines 3054 3051 -3
==========================================
- Hits 2525 2521 -4
- Misses 529 530 +1 ☔ View full report in Codecov by Sentry. |
|
Alright, I think I fixed the remaining test issues so this is passing on all versions now |
|
bumping this. |
quinnj
approved these changes
Mar 5, 2024
nickrobinson251
pushed a commit
that referenced
this pull request
Feb 5, 2025
* Update readbytes! to avoid using internal API of IOBuffer less Note that this claims to be supported for all GenericIOBuffer, but Base only defines this function on a normal IOBuffer for which `pointer(data)` is contiguous space * Update Streams.jl * Update Streams.jl * Update Streams.jl * fix some tests relying on implementation details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this claims to be supported for all GenericIOBuffer, but Base only defines this function on a normal IOBuffer for which
pointer(data)is contiguous space