Skip to content

Re-enable tests with compiled_modules=False #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2021
Merged

Re-enable tests with compiled_modules=False #463

merged 2 commits into from
Oct 25, 2021

Conversation

tkf
Copy link
Member

@tkf tkf commented Oct 25, 2021

This should work, now that #459 was fixed by JuliaPy/PyCall.jl#937

@tkf
Copy link
Member Author

tkf commented Oct 25, 2021

waiting JuliaPy/PyCall.jl#938

@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #463 (30d1205) into master (f577d9d) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #463      +/-   ##
==========================================
+ Coverage   88.98%   89.00%   +0.01%     
==========================================
  Files          39       39              
  Lines        2269     2264       -5     
==========================================
- Hits         2019     2015       -4     
+ Misses        250      249       -1     
Impacted Files Coverage Δ
src/julia/tests/test_libjulia.py 100.00% <ø> (ø)
src/julia/tests/test_sysimage.py 100.00% <ø> (+2.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f577d9d...30d1205. Read the comment docs.

@tkf tkf marked this pull request as ready for review October 25, 2021 02:36
@tkf tkf enabled auto-merge (squash) October 25, 2021 02:36
@tkf tkf merged commit bee73ec into JuliaPy:master Oct 25, 2021
@tkf tkf deleted the nomain branch October 25, 2021 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant