Added ProtocolBuffers #10436
Draft
Added ProtocolBuffers #10436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Temporarily also added ProtocolBuffersCompiler - this should likely depend on ProtocolBuffers ( |
…c recipe ProtocolBuffers only includes libprotobuf and libprotobuf-lite shared libraries. ProtocolBuffersSDK only includes static libraries. Static libraries are compiled as position independent code, cf. https://github.com/onnx/onnx/blob/v1.17.0/README.md#linux Removes need for custom versioning, cf. notes about protobuf version numbers.
stemann
force-pushed
the
feature/ProtocolBuffers
branch
from
8ba969c to
2b9fce7
Compare
|
One could also consider adding |
giordano
reviewed
Feb 16, 2025
There was a problem hiding this comment.
Care to elaborate what this is doing?
There was a problem hiding this comment.
Just blindly copied from protoc recipe
There was a problem hiding this comment.
I can try removing it
giordano
reviewed
Feb 16, 2025
Co-authored-by: Mosè Giordano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is
protoc_jll, which provides the protobuf compiler,protoc, and thelibprotobuf, andlibprotobuf-literun-time libraries (in shared library form), but not the static run-time libraries - and the versioning got a bit off course, cf. #9796.Since
it is very much preferable to link with
libprotobufstatically, and not dynamically. Cf. https://protobuf.dev/support/cross-version-runtime-guarantee/#cppIn Yggdrasil, there are packages that have
protoc_jllas aHostBuildDependency, but there are also packages that need the run-time libraries and haveprotoc_jllas aDependency.The present PR accomplishes the following goals:
ProtocolBuffersCompiler),ProtocolBuffers, andProtocolBuffersSDK)ProtocolBuffersSDK), cf. recommendation from https://github.com/onnx/onnx/blob/v1.17.0/README.md#linuxProtocolBuffers.Over time, these packages could replace
protoc_jll.