Add unnormalized sinc/sinhc functions #492
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #492 +/- ##
==========================================
+ Coverage 94.11% 94.17% +0.05%
==========================================
Files 14 15 +1
Lines 2905 2934 +29
==========================================
+ Hits 2734 2763 +29
Misses 171 171
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mattsignorelli
changed the title
|
@stevengj hello! I am sure you are quite busy, but just wanted to send a ping and see if this would be merged. Thanks! |
|
Perhaps @oscardssmith can take a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Julia currently does not have any official implementations for the unnormalized sinc function, nor the hyperbolic sinc function. There has been much discussion about this (see JuliaLang/julia#55981, JuliaLang/julia#36954 (comment), https://discourse.julialang.org/t/unnormalized-sinc/25015/15, etc etc). My interpretation is that these functions for Julia v1.0 should go in
SpecialFunctions.jl. If this is correct, then I have implemented thesincuandsinchufunctions which are the unnormalized sine cardinal and hyperbolic unnormalized sine cardinal respectively. These functions are basically copy-pasted from the Boost C++ library (sinc and sinhc). Appropriate tests checking each of the thresholds have also been added.I imagine we will want
coscuas well as asinhcat some point, but this PR would at least get the ball rolling and provide an "official" implementation of thesincuandsinhcufunctions to interested downstream users.