Fix for #137 #138
Merged
Fix for #137 #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxinabox
reviewed
Oct 2, 2023
| with_logger(lg) do | ||
| @info "x" val=3.0 | ||
| end | ||
| hist = convert(MVHistory, lg) |
There was a problem hiding this comment.
this is the line that is failing. Is what we need:
Suggested change
| hist = convert(MVHistory, lg) | |
| hist = convert(ValueHistories.MVHistory, lg) |
Or do we need to make sure ValueHistories.jl is loaded?
There was a problem hiding this comment.
Ah I think I've gotten confused by the fact that ValueHistories.jl is listed as a dep for the test target in the Project.toml, and thus assumed it was already loaded. I loaded it in runtests.jl now:) Should hopefully do the trick.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #137
Not sure if this is the way to go, but figured I'd submit it in case it's useful.