Convert lower to upper bidgiagonal in _svd! and _svdvals! #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasnoack
force-pushed
the
an/lowertoupper
branch
4 times, most recently
from
bfa8c1d to
4c14a98
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #158 +/- ##
==========================================
+ Coverage 96.32% 96.42% +0.10%
==========================================
Files 10 10
Lines 1441 1454 +13
==========================================
+ Hits 1388 1402 +14
+ Misses 53 52 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This is done by running a single pass of givens rotations from the left while also updating the U matrix. For svdvals!, the uplo field is simply flipped as the singular values of the transpose are the same.
andreasnoack
force-pushed
the
an/lowertoupper
branch
from
4c14a98 to
477ba23
Compare
This was referenced Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done by running a single pass of givens rotations from the left while also updating the U matrix. For svdvals!, the uplo field is simply flipped as the singular values of the transpose are the same.
Supersedes #156. Closes #157.